From ab1c597e1cd8b5459dc3d937f8708435f5e36e49 Mon Sep 17 00:00:00 2001
From: kangfenmao <kangfenmao@qq.com>
Date: Sat, 26 Oct 2024 22:38:31 +0800
Subject: [PATCH] refactor: improved code readability for filtering agents

---
 src/renderer/src/pages/agents/AgentsPage.tsx | 46 ++++++++------------
 1 file changed, 17 insertions(+), 29 deletions(-)

diff --git a/src/renderer/src/pages/agents/AgentsPage.tsx b/src/renderer/src/pages/agents/AgentsPage.tsx
index 229cfc77..aaae985b 100644
--- a/src/renderer/src/pages/agents/AgentsPage.tsx
+++ b/src/renderer/src/pages/agents/AgentsPage.tsx
@@ -6,8 +6,8 @@ import { createAssistantFromAgent } from '@renderer/services/assistant'
 import { Agent } from '@renderer/types'
 import { uuid } from '@renderer/utils'
 import { Col, Input, Row, Tabs as TabsAntd, Typography } from 'antd'
-import { debounce, groupBy, omit } from 'lodash'
-import { FC, useEffect, useMemo, useState } from 'react'
+import { groupBy, omit } from 'lodash'
+import { FC, useMemo, useState } from 'react'
 import { useTranslation } from 'react-i18next'
 import ReactMarkdown from 'react-markdown'
 import styled from 'styled-components'
@@ -30,33 +30,25 @@ const getAgentsFromSystemAgents = () => {
 
 const AgentsPage: FC = () => {
   const [search, setSearch] = useState('')
-  const [filteredAgentGroups, setFilteredAgentGroups] = useState({})
   const agentGroups = useMemo(() => groupBy(getAgentsFromSystemAgents(), 'group'), [])
   const { t } = useTranslation()
 
-  const debouncedSearch = useMemo(
-    () =>
-      debounce((searchTerm: string) => {
-        if (!searchTerm.trim()) {
-          setFilteredAgentGroups(agentGroups)
-          return
-        }
+  const filteredAgentGroups = useMemo(() => {
+    if (!search.trim()) return agentGroups
 
-        const filtered = {}
-        Object.entries(agentGroups).forEach(([group, agents]) => {
-          const filteredAgents = agents.filter(
-            (agent) =>
-              agent.name.toLowerCase().includes(searchTerm.toLowerCase()) ||
-              agent.prompt?.toLowerCase().includes(searchTerm.toLowerCase())
-          )
-          if (filteredAgents.length > 0) {
-            filtered[group] = filteredAgents
-          }
-        })
-        setFilteredAgentGroups(filtered)
-      }, 500),
-    [agentGroups]
-  )
+    const filtered = {}
+    Object.entries(agentGroups).forEach(([group, agents]) => {
+      const filteredAgents = agents.filter(
+        (agent) =>
+          agent.name.toLowerCase().includes(search.toLowerCase()) ||
+          agent.prompt?.toLowerCase().includes(search.toLowerCase())
+      )
+      if (filteredAgents.length > 0) {
+        filtered[group] = filteredAgents
+      }
+    })
+    return filtered
+  }, [agentGroups, search])
 
   const getAgentName = (agent: Agent) => {
     return agent.emoji ? agent.emoji + ' ' + agent.name : agent.name
@@ -91,10 +83,6 @@ const AgentsPage: FC = () => {
     }
   }
 
-  useEffect(() => {
-    debouncedSearch(search)
-  }, [search, debouncedSearch])
-
   return (
     <Container>
       <Navbar>