From 5347f63aa8b43dbecef3cd06588a4cf4f09a0a37 Mon Sep 17 00:00:00 2001
From: kangfenmao <kangfenmao@qq.com>
Date: Thu, 24 Oct 2024 15:05:13 +0800
Subject: [PATCH] =?UTF-8?q?fix:=20=E6=B7=BB=E5=8A=A0=E9=BB=98=E8=AE=A4?=
 =?UTF-8?q?=E5=8A=A9=E6=89=8B=E4=BC=9A=E6=B7=BB=E5=8A=A0=E4=B8=A4=E4=B8=AA?=
 =?UTF-8?q?=20#238?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../components/Popups/AddAssistantPopup.tsx   |  6 ++--
 .../components/Popups/SelectModelPopup.tsx    | 33 ++++++++++---------
 .../src/components/Popups/TextEditPopup.tsx   |  1 -
 3 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/src/renderer/src/components/Popups/AddAssistantPopup.tsx b/src/renderer/src/components/Popups/AddAssistantPopup.tsx
index 6a922ee5..dcf410e3 100644
--- a/src/renderer/src/components/Popups/AddAssistantPopup.tsx
+++ b/src/renderer/src/components/Popups/AddAssistantPopup.tsx
@@ -6,6 +6,7 @@ import { useAssistants, useDefaultAssistant } from '@renderer/hooks/useAssistant
 import { createAssistantFromAgent } from '@renderer/services/assistant'
 import { EVENT_NAMES, EventEmitter } from '@renderer/services/event'
 import { Agent, Assistant } from '@renderer/types'
+import { uuid } from '@renderer/utils'
 import { Divider, Input, InputRef, Modal, Tag } from 'antd'
 import { useEffect, useMemo, useRef, useState } from 'react'
 import { useTranslation } from 'react-i18next'
@@ -36,7 +37,7 @@ const PopupContainer: React.FC<Props> = ({ resolve }) => {
 
   const onCreateAssistant = async (agent: Agent) => {
     if (agent.id === 'default') {
-      addAssistant(agent)
+      addAssistant({ ...agent, id: uuid() })
       return
     }
 
@@ -66,8 +67,7 @@ const PopupContainer: React.FC<Props> = ({ resolve }) => {
       open={open}
       onCancel={onCancel}
       afterClose={onClose}
-      transitionName="ant-move-down"
-      maskTransitionName="ant-fade"
+      transitionName="ant-move-up"
       styles={{ content: { borderRadius: 20, padding: 0, overflow: 'hidden', paddingBottom: 20 } }}
       closeIcon={null}
       footer={null}>
diff --git a/src/renderer/src/components/Popups/SelectModelPopup.tsx b/src/renderer/src/components/Popups/SelectModelPopup.tsx
index 937ebdb8..5e1f3aae 100644
--- a/src/renderer/src/components/Popups/SelectModelPopup.tsx
+++ b/src/renderer/src/components/Popups/SelectModelPopup.tsx
@@ -12,6 +12,7 @@ import { useTranslation } from 'react-i18next'
 import styled from 'styled-components'
 
 import { HStack } from '../Layout'
+import { Scrollbar } from '../Scrollbar'
 
 type MenuItem = Required<MenuProps>['items'][number]
 
@@ -102,28 +103,28 @@ const PopupContainer: React.FC<PopupContainerProps> = ({ model, resolve }) => {
         />
       </HStack>
       <Divider style={{ margin: 0, borderBlockStartWidth: 0.5 }} />
-      <Container>
-        {filteredItems.length > 0 ? (
-          <StyledMenu
-            items={filteredItems}
-            selectedKeys={model ? [getModelUniqId(model)] : []}
-            mode="inline"
-            inlineIndent={6}
-          />
-        ) : (
-          <EmptyState>
-            <Empty image={Empty.PRESENTED_IMAGE_SIMPLE} />
-          </EmptyState>
-        )}
-      </Container>
+      <Scrollbar style={{ height: '50vh' }}>
+        <Container>
+          {filteredItems.length > 0 ? (
+            <StyledMenu
+              items={filteredItems}
+              selectedKeys={model ? [getModelUniqId(model)] : []}
+              mode="inline"
+              inlineIndent={6}
+            />
+          ) : (
+            <EmptyState>
+              <Empty image={Empty.PRESENTED_IMAGE_SIMPLE} />
+            </EmptyState>
+          )}
+        </Container>
+      </Scrollbar>
     </Modal>
   )
 }
 
 const Container = styled.div`
-  height: 50vh;
   margin-top: 10px;
-  overflow-y: auto;
 `
 
 const StyledMenu = styled(Menu)`
diff --git a/src/renderer/src/components/Popups/TextEditPopup.tsx b/src/renderer/src/components/Popups/TextEditPopup.tsx
index 2e20e3c5..d03bb423 100644
--- a/src/renderer/src/components/Popups/TextEditPopup.tsx
+++ b/src/renderer/src/components/Popups/TextEditPopup.tsx
@@ -55,7 +55,6 @@ const PopupContainer: React.FC<Props> = ({ text, textareaProps, modalProps, reso
       width="60vw"
       style={{ maxHeight: '70vh' }}
       transitionName="ant-move-down"
-      maskTransitionName="ant-fade"
       okText={t('common.save')}
       {...modalProps}
       open={open}