fix(AssistantSettings): temporarily disable transitionName to resolve modal closing issues in production

This commit is contained in:
fullex 2025-04-16 08:30:46 +08:00 committed by 亢奋猫
parent cf61ae927c
commit 2408566d34

View File

@ -85,7 +85,28 @@ const AssistantSettingPopupContainer: React.FC<Props> = ({ resolve, tab, ...prop
afterClose={afterClose} afterClose={afterClose}
footer={null} footer={null}
title={assistant.name} title={assistant.name}
transitionName="ant-move-down" /*******************************************
* IMPORTANT: The Comment of transitionName is because:
*
* When in the production mode,
* if some of the antd components(like Select or not showing the assistant tab) not loaded beforehand,
* the modal will not close properly when using unofficially transitionName(like ant-move-down).
*
* The resason may be that the antd CSS-in-JS is not loaded the unofficially ant-xxx-xxx motions,
* this will cause the modal close process being interrupted.
* see antd issue for more details: https://github.com/ant-design/ant-design/issues/29626
*
* The deeper reason may be that the css/js chunking handle method is different between dev and prod envs
* If we want to solve the problem completely, we need to refactor the antd someway.
*
* The temporary solution is:
* 1. not set transitionName (transitionName is no longer supported in antd 5+)
* 2. set timeout to execute the modal resolve()
* 3. load the other complex antd components(like Select) beforehand
*
* we take the first solution for now.
*/
// transitionName="ant-move-down"
styles={{ styles={{
content: { content: {
padding: 0, padding: 0,